Use LOCALAPPDATA for system cache on windows - #2297
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1166f02 to
f872018
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
This is a nice fix... I only have two nits, if you don't do those we'll probably do it and land..
Note to self: ensure we have a good commit message so we can explain this in dart-sdk CHANGELOG when we roll pub in...
| var appData = Platform.environment['APPDATA']; | ||
| return p.join(appData, 'Pub', 'Cache'); | ||
| var appDataCacheDir = p.join(appData, 'Pub', 'Cache'); | ||
| if (Directory(appDataCacheDir).existsSync()) { |
There was a problem hiding this comment.
nit, but for consistency with the rest of the code base can we consider using dirExists(dir).
| if (Platform.environment.containsKey('PUB_CACHE')) { | ||
| return Platform.environment['PUB_CACHE']; | ||
| } else if (Platform.isWindows) { | ||
| // If a cache dir already exists in %APPDATA%, use it, else default to %LOCALAPPDATA% |
There was a problem hiding this comment.
nit, Can we briefly explain that we prefer %APPDATA% if it already exists because older pub versions created the pub-cache here.
And maybe state that using %LOCALAPPDATA% is better because it's not synchronized.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
6f0cfd4 to
f26a056
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
f26a056 to
f650df5
Compare
3 participants
Currently, the default location for pub's system cache is in %APPDATA%, which means it is in the roaming profile that gets synced across devices. This is less than ideal because it can get pretty large.
This PR moves the default location of the cache to %LOCALAPPDATA%, but will use %APPDATA% if the cache already exists there to avoid breaking existing installs linking to that location
Fixes #1273