Use LOCALAPPDATA for system cache on windows #2297

Jesse-Bakker · 2020-01-07T11:36:02Z

Currently, the default location for pub's system cache is in %APPDATA%, which means it is in the roaming profile that gets synced across devices. This is less than ideal because it can get pretty large.

This PR moves the default location of the cache to %LOCALAPPDATA%, but will use %APPDATA% if the cache already exists there to avoid breaking existing installs linking to that location

Fixes #1273

googlebot · 2020-01-07T11:36:06Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Jesse-Bakker · 2020-01-07T11:38:03Z

@googlebot I signed it!

googlebot · 2020-01-07T11:38:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-07T11:41:52Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jonasfj

This is a nice fix... I only have two nits, if you don't do those we'll probably do it and land..

Note to self: ensure we have a good commit message so we can explain this in dart-sdk CHANGELOG when we roll pub in...

jonasfj · 2020-01-08T15:34:56Z

lib/src/system_cache.dart

      var appData = Platform.environment['APPDATA'];
-      return p.join(appData, 'Pub', 'Cache');
+      var appDataCacheDir = p.join(appData, 'Pub', 'Cache');
+      if (Directory(appDataCacheDir).existsSync()) {


nit, but for consistency with the rest of the code base can we consider using dirExists(dir).

jonasfj · 2020-01-08T15:36:21Z

lib/src/system_cache.dart

@@ -35,8 +35,14 @@ class SystemCache {
    if (Platform.environment.containsKey('PUB_CACHE')) {
      return Platform.environment['PUB_CACHE'];
    } else if (Platform.isWindows) {
+      // If a cache dir already exists in %APPDATA%, use it, else default to %LOCALAPPDATA%


nit, Can we briefly explain that we prefer %APPDATA% if it already exists because older pub versions created the pub-cache here.
And maybe state that using %LOCALAPPDATA% is better because it's not synchronized.

googlebot · 2020-01-08T15:57:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-08T15:59:56Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jonasfj

googlebot added the cla: no label Jan 7, 2020

Use LOCALAPPDATA for system cache on windows

f872018

Jesse-Bakker force-pushed the windows-local-appdata branch from 1166f02 to f872018 Compare January 7, 2020 11:41

googlebot added cla: yes and removed cla: no labels Jan 7, 2020

Formatting

9024daa

kevmoo requested a review from jonasfj January 7, 2020 16:18

jonasfj approved these changes Jan 8, 2020

View reviewed changes

googlebot added cla: no and removed cla: yes labels Jan 8, 2020

Jesse-Bakker force-pushed the windows-local-appdata branch from 6f0cfd4 to f26a056 Compare January 8, 2020 15:59

googlebot added cla: yes and removed cla: no labels Jan 8, 2020

Jesse-Bakker added 2 commits January 8, 2020 17:04

Use dirExists instead of Directory.existsSync for consistency

e0f918a

Explain why we fall back to %APPDATA% if it exists

f650df5

Jesse-Bakker force-pushed the windows-local-appdata branch from f26a056 to f650df5 Compare January 8, 2020 16:05

jonasfj approved these changes Jan 8, 2020

View reviewed changes

jonasfj merged commit 82e60a3 into dart-lang:master Jan 9, 2020

Jesse-Bakker deleted the windows-local-appdata branch January 10, 2020 21:56

This was referenced Jul 16, 2020

Update documentation for Windows pub cache location to from APPDATA to LOCALAPPDATA dart-lang/site-www#2526

Closed

List pub cache location: pub cache show #1107

Closed

Update Windows pub cache path from APPDATA to LOCALAPPDATA dart-lang/site-www#2527

Merged

kinex mentioned this pull request Feb 1, 2021

pub get fails to "package doesn't exist" in Windows #2858

Closed

sigurdm mentioned this pull request Mar 14, 2023

Remove support for PUB_CACHE in APPDATA on windows #3831

Merged

julemand101 mentioned this pull request Aug 17, 2023

Replace AppData\Roaming\Pub\Cache\bin with AppData\Local\Pub\Cache\bin in PATH dart-lang/chocolatey-packages#11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use LOCALAPPDATA for system cache on windows #2297

Use LOCALAPPDATA for system cache on windows #2297

Jesse-Bakker commented Jan 7, 2020 •

edited

Loading

googlebot commented Jan 7, 2020

Jesse-Bakker commented Jan 7, 2020

googlebot commented Jan 7, 2020

googlebot commented Jan 7, 2020

jonasfj left a comment

jonasfj Jan 8, 2020

jonasfj Jan 8, 2020

googlebot commented Jan 8, 2020

googlebot commented Jan 8, 2020

jonasfj left a comment

Use LOCALAPPDATA for system cache on windows #2297

Use LOCALAPPDATA for system cache on windows #2297

Conversation

Jesse-Bakker commented Jan 7, 2020 • edited Loading

googlebot commented Jan 7, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Jesse-Bakker commented Jan 7, 2020

googlebot commented Jan 7, 2020

googlebot commented Jan 7, 2020

jonasfj left a comment

Choose a reason for hiding this comment

jonasfj Jan 8, 2020

Choose a reason for hiding this comment

jonasfj Jan 8, 2020

Choose a reason for hiding this comment

googlebot commented Jan 8, 2020

googlebot commented Jan 8, 2020

jonasfj left a comment

Choose a reason for hiding this comment

Jesse-Bakker commented Jan 7, 2020 •

edited

Loading